Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keycloak 24 #997

Closed
wants to merge 4 commits into from
Closed

Add Keycloak 24 #997

wants to merge 4 commits into from

Conversation

lme-atolcd
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #996

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

tbroyer referenced this pull request Mar 8, 2024
@snyk-bot
fix: upgrade net.logstash.logback:logstash-logback-encoder from 7.2 t…
7ef74f9 
…o 7.4

Snyk has created this PR to upgrade net.logstash.logback:logstash-logback-encoder from 7.2 to 7.4.

See this package in Maven Repository:
https://mvnrepository.com/artifact/net.logstash.logback/logstash-logback-encoder/

See this project in Snyk:
https://app.snyk.io/org/st3v0rr/project/b05cc1c7-f375-446c-b681-f981b0c66285?utm_source=github&utm_medium=referral&page=upgrade-pr
@jonasvoelcker
Copy link
Collaborator

Hi @lme-atolcd,

as there were breaking changes in 23.0.4 we do need to add my pull request as well: #977

Could you please try to merge my branch into yours and see whether everything keeps working?

I am currently stuffed with other things on the project but I will also try to add the 24 within the next week, I think ;)

Best Regards
Jonas

P.S.: @st3v0rr Could you please give a sign of life? ^^

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lme-atolcd
Copy link
Contributor Author

Hi @jonasvoelcker

I rebased my branch on top of yours.
Still wondering why my pull-request fails on Github CI (local tests are ok) 😄

[ERROR] de.adorsys.keycloak.config.service.GroupImportServiceTest$CreatingGroupIT.createOrUpdateGroups_shouldCreateGroup  Time elapsed: 0.007 s  <<< ERROR!
java.lang.NoSuchMethodError: 'java.time.Instant ch.qos.logback.classic.spi.ILoggingEvent.getInstant()'
	at de.adorsys.keycloak.config.service.GroupImportServiceTest$CreatingGroupIT.createOrUpdateGroups_shouldCreateGroup(GroupImportServiceTest.java:85)

If you have an idea...

@tbroyer
Copy link
Contributor

tbroyer commented Mar 8, 2024

Fwiw, this could be an explanation (but no idea why it manifests here and not elsewhere): 7ef74f9#r139546567

@jonasvoelcker
Copy link
Collaborator

Hi @lme-atolcd, it was exactly what @tbroyer mentioned and I downgraded it to 7.3.

Furthermore there was a change in the return values of groups so I needed to change some if-statements.

My branch seems to work now, thanks for your Feature-Flag-Analysis :)

#998

@lme-atolcd
Copy link
Contributor Author

@jonasvoelcker okay, that's good news :)
Let's continue with your pull request then.

@lme-atolcd lme-atolcd closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keycloak 24
3 participants
@lme-atolcd @jonasvoelcker @tbroyer